From 9f08eb2171d73bf00edb8b41ee4acc0306ef28ef Mon Sep 17 00:00:00 2001
From: KoloMl <thekolomoets@hotmail.com>
Date: Mon, 17 Feb 2025 03:46:29 +0400
Subject: [PATCH] Refactored MenuItem

This change will break a lot of menu items with `on:click`. These cases would be resolved separately.
---
 src/components/ui/menu/MenuItem.svelte | 31 ++++++++++++--------------
 1 file changed, 14 insertions(+), 17 deletions(-)

diff --git a/src/components/ui/menu/MenuItem.svelte b/src/components/ui/menu/MenuItem.svelte
index aa5a29d..eedcad0 100644
--- a/src/components/ui/menu/MenuItem.svelte
+++ b/src/components/ui/menu/MenuItem.svelte
@@ -1,28 +1,25 @@
-<script>
-  import { createBubbler } from 'svelte/legacy';
+<script lang="ts">
+  import type { Snippet } from "svelte";
+  import type { MouseEventHandler } from "svelte/elements";
 
-  const bubble = createBubbler();
+  interface MenuItemProps {
+    href?: string | null;
+    icon?: App.IconName | null;
+    target?: App.LinkTarget | undefined;
+    children?: Snippet;
+    onclick?: MouseEventHandler<HTMLAnchorElement | HTMLSpanElement>;
+  }
 
-
-  /**
-   * @typedef {Object} Props
-   * @property {string|null} [href]
-   * @property {App.IconName|null} [icon]
-   * @property {App.LinkTarget|undefined} [target]
-   * @property {import('svelte').Snippet} [children]
-   */
-
-  /** @type {Props} */
   let {
     href = null,
     icon = null,
     target = undefined,
-    children
-  } = $props();
+    children,
+    onclick
+  }: MenuItemProps = $props();
 </script>
 
-<svelte:element class="menu-item" {href} onclick={bubble('click')} role="link" tabindex="0" {target}
-                this="{href ? 'a': 'span'}">
+<svelte:element class="menu-item" {href} {onclick} role="link" tabindex="0" {target} this="{href ? 'a': 'span'}">
   {#if icon}
     <i class="icon icon-{icon}"></i>
   {/if}